saf-review-pr ยท diff
v6.5.0 to git:20260826.655710e
3 added, 17 removed. Audit A to A.
---
name: saf-review-pr
description: Review one task-scoped pull request against its SDD, diff, and configured checks. Use for an evidence-based PR review; not for fixing findings or mutating PR metadata.
- metadata:
- version: 6.5.0
- extends: saf-create-pr
- requires: [config, change-review-package]
- consumes: []
- produces: [review-findings]
- baseline: [tlc-spec-driven]
- depends_on: []
- conflicts: []
- requires_cli: null
- autonomy_profile:
- supported_levels: [manual, supervised, autonomous]
- auto_continue_condition: 'review-findings present and every finding evidence-backed; actionable findings route to bounded repair'
- blocking_conditions: [unverified_findings, authority_boundary, no_progress]
- evidence_required: [review-findings]
+ compatibility: Requires Git and a compatible Agent Skills host.
---
# Review an SDD pull request
## When to use
Use after a task-scoped local change-review package is ready, or when the user asks to review a PR associated with one SDD task. Read [the TLC baseline](../sdd-agentic-flow-shared/references/tlc-baseline.md), [engineering principles](../sdd-agentic-flow-shared/references/engineering-principles.md), and [safety rules](../sdd-agentic-flow-shared/references/workflow-safety.md).
## When not to use
Do not use to implement fixes, validate a whole feature, create a PR, or review a PR whose task scope cannot be resolved.
## Inputs
- Local change-review package or local diff context plus one task reference.
- - `.sdd-agentic-flow/config.yml`, task SDD artifacts, diff, and available check evidence.
+ - Optional `.sdd-agentic-flow/config.yml` overrides, task SDD artifacts, diff, and available check evidence.
## Workflow
- 1. Read `.sdd-agentic-flow/config.yml` first; if it is missing, ask the user to run `/saf-setup` or `npx sdd-agentic-flow init`, then resolve the task, base, and head context from local artifacts.
+ 1. Read `.sdd-agentic-flow/config.yml` when present; otherwise use canonical effective defaults, then resolve the task, base, and head context from local artifacts.
2. Make two independent judgments: (1) spec/correctness against the SDD package, (2) engineering fit against `../sdd-agentic-flow-shared/references/engineering-principles.md` and repo conventions. Pretty code must not hide a spec miss. A spec-correct but over-engineered change is a quality finding, not an automatic block. Review acceptance criteria, changed behavior, tests, scope boundaries, and configured quality/security expectations.
3. Verify findings with code or reproducible evidence, applying `../sdd-agentic-flow-shared/references/evidence-standard.md`. Separate blocking defects from non-blocking observations; do not invent CI results; do not invent done.
4. Produce a Markdown-first findings ledger with state (`confirmed`, `not-reproduced`, `evidence-gap`, `spec-conflict`, `human-judgment`, `resolved`, or `deferred`), severity, file/line, evidence, required remediation, and re-review focus. In autonomous mode, verified actionable findings authorize `saf-fix-pr` and re-review without a new confirmation; this Skill remains read-only.
## Safety
Operate read-only. Do not submit reviews, comments, approvals, labels, assignments, status changes, code edits, Git mutations, or network mutations by default.
## Output
Return `approved`, `changes requested`, `blocked`, or `inconclusive`, plus the scoped findings ledger, check evidence, and next step. Include `Status`, `Next recommended skill`, and `Reason`.
### Autonomy
Supports `manual`, `supervised`, and `autonomous` autonomy levels. Autonomy governs whether the
workflow advances after this Skill completes: verified actionable findings route to `saf-fix-pr`,
then back to review; a clean review can advance to `saf-validate`. This Skill never corrects a
finding automatically. See `../sdd-agentic-flow-shared/references/autonomy-guardrails.md`.