repo-harness-cross-review · diff
git:20261002.cc1fc8e to git:20261002.cdeca8c
16 added, 25 removed. Audit A to A.
---
name: repo-harness-cross-review
- description: Independent outside review of the current review scope (branch diff plus staged, unstaged, untracked changes). Uses the explicit Codex advisory provider; generic acceptance uses a persistent fleet deep-reasoner task-agent in Herdr. Use before merging, after a tricky change, or for a debug second opinion.
- when_to_use: "cross review, second opinion, outside voice, codex review, 让 codex 审, 找外部意见, 二审"
+ description: Independent acceptance review through the persistent fleet deep-reasoner task-agent in Herdr. Generic review owns scope, request-bound Result validation and typed Receipt; the old direct advisory runtime is retired.
+ when_to_use: "cross review, second opinion, outside voice, codex review, independent review, 让 codex 审, 找外部意见, 二审"
---
# repo-harness-cross-review
- Canonical rule owner for independent outside review. Scope capture, provider
- invocation, timeout, structured-output validation, and error classification live in
- code (`src/core/review`, `src/effects/review`,
- `src/cli/commands/cross-review.ts`); this package owns only when to invoke,
- how to interpret findings, and the boundaries below.
+ Canonical routing guidance for the existing generic review domain. Runtime
+ ownership lives in `src/effects/review/generic-review.ts`, the OAR host and
+ `src/effects/terminal/task-session.ts`; the Skill does not implement a provider.
## Mode Selection
- - Explicit Codex advisory review: `references/codex-mode.md`.
- - Acceptance review through task-agent -> `references/generic-review.md`.
- - An explicit provider request wins over the host default.
-
- ## When to use
-
- - Before merging an important diff (last gate).
- - After writing a spec/tests -- find ambiguity and weak assertions.
- - A hard bug whose root cause is unclear (independent diagnosis).
-
- ## Interpreting findings
-
- - Present the transcript verbatim -- never summarize or soften it.
- - Any `[P1]` finding -> **FAIL** (do not merge until addressed). Only `[P2]` or none -> **PASS**.
- - Agreement raises confidence; divergence is where to dig. A recommendation, not a decision -- you decide.
+ - Acceptance through persistent Herdr task-agent: `references/generic-review.md`.
+ - Migration from the retired direct Codex advisory command: `references/codex-mode.md`.
+ - Explicit harness selection belongs to `repo-harness review round --harness`.
## Boundaries
- - Read-only: direct Codex uses a read-only sandbox.
- - Bounded: 2 provider attempts, then `SKIPPED` -- advisory, non-blocking (exit 0). Do not re-run it or narrow the diff to retry. `degraded_scope` and `stale_scope` block (exit 1). Never a synthesized pass.
- - Never produces or verifies a `merge-gate` receipt; that judge is separate.
+ Prepare verification and the contract before review. The existing fleet
+ `deep-reasoner` role, addressed Herdr pane, isolated reviewer checkout and OAR
+ Session own the run. History/idle are observations; the request-bound file Result
+ and generic-review Receipt own acceptance. Unknown model, delivery or cleanup
+ stays unverified or pending. Never synthesize PASS, alias the retired command,
+ replay an ambiguous request or bypass a frozen reviewer policy. Review does not
+ merge; the owner makes that separate decision. Use only the documented admitted
+ runtime/isolation boundary; library permission approval is not an OS sandbox.