code-review · git:20260805.0af56c6 · 2026-08-05 · sha256 486515c6f8dda4f8
code-review git:20260805.0af56c6A
Immutable. This exact content is served forever at /api/v1/blob/486515c6f8dda4f8.
--- name: code-review description: Use this skill when you need a risk-driven code review of a PR/diff with severity-ranked findings and actionable fixes; triggers include code review, PR review, and 代码审查. --- # Code Review **中文版:** See the corresponding Chinese skill. ## When to Use - Need to review a PR / diff / commit and catch logic, security, financial-loss, or maintainability risks before merge. - Need a P0/P1/P2-ranked report with locations and actionable fix guidance. - Need a QA / engineering-quality lens beyond author self-review. ## Workflow 1. Read and follow the main prompt listed under Progressive disclosure (coverage, structure, quality bar). 2. Add only project context that changes the result: change scope, business goal, stack, upstream/downstream deps, known risks, team norms. 3. If input is incomplete, return a usable first draft and explicitly mark assumptions and gaps. 4. Default to Markdown; switch formats only when the user asks. ## Core Constraints - Risk-driven: prioritize production failures, financial loss, security, and core maintainability — not naming/indent noise. - Evidence-based: prefer file path, line, or snippet plus trigger path and impact for each finding. - Strict severity: P0 blocks merge, P1 should fix this iteration, P2 can be tech debt. - Separate confirmed facts from assumptions; do not invent endpoints, fields, environments, or root causes the user did not provide. - Critique the code, not the author; respect the current stack — do not demand framework/architecture rewrites without authorization. - Keep output executable: every finding needs a fix direction or before/after example. ## Progressive Disclosure - Before producing output, read and follow `prompts/code-review.md` (minimum coverage, output structure, quality bar). - When Excel/CSV/JSON/Word is requested: read `output-formats.md` and honor the format. - When a ready-made template fits: use matching files under `output-templates/`. - For deeper review dimensions or severity rubrics: read `references/review-dimensions.md`. - For examples or calibration: read matching files under `examples/`. - For format conversion or helper checks: prefer existing `scripts/` over reinventing. - For the shortest path: read `quick-start.md`. - For evaluating/regressing this skill: use `evals/` with skill-up. ## Pre-delivery Checklist - [ ] Followed the main prompt's output structure - [ ] Minimum coverage focus: change summary, overall risk rating, P0/P1/P2 list, testability/observability, API/contract compatibility, fix order, residual risks and assumptions… (details in main prompt) - [ ] Covered the minimum checklist, or explained omissions - [ ] High-risk items have explicit P0/P1 severity with rationale - [ ] Did not invent details the user did not provide - [ ] Assumptions and gaps are marked ## Common Pitfalls - Do not pretend completeness when scope/diff is missing. - Do not treat every item as equally important, or dump low-value style nits. - Do not skip assumptions and information gaps. - Do not force refactors outside the change under review. - Do not dump generic theory unrelated to this change.