code-review · diff

git:20261102.bc6f8af to git:20261109.c329eb3

3 added, 1 removed. Audit A to A.

What this update changes in the checks

No check changed: every fixed check gives the same answer before and after this update.

A tripped check is a label, not a verdict: read the matched text and the lines below. This week's updates that newly trip a check.

---
name: code-review
description: Reviews code changes along two axes—specification fidelity and engineering standards (security, concurrency, architecture, and Ponytail minimalism). Use when reviewing diffs, pull requests, branches, or checking code quality.
---
# Code Review
Review the diff between `HEAD` and a base reference along two axes: **Specification Fidelity** and **Engineering Standards**.
## Decision tree
1. **Is the base ref (commit, branch, or working-tree diff) resolved and non-empty?**
- **No** → Inspect `git status` and `git diff` (or ask the user for the base ref) before starting.
- **Yes** → Proceed to step 2.
2. **Are you reviewing your own recent implementation or a multi-module diff?**
- **Yes** → Delegate the review to `adversarial-reviewer` via `invoke_subagent` so findings remain free of confirmation bias.
- **No** → Execute the review workflow below directly.
## Review workflow
1. **Capture diff & check unchanged callers**:
- Run `git diff <base>...HEAD` (or `git diff`) via `run_command`.
- For every modified function signature or shared type, run `grep_search` across the repo to confirm unchanged callers are not broken.
2. **Audit Axis 1 — Specification Fidelity & Test Integrity**:
- - Verify the diff fulfills all requirements and acceptance criteria from the originating spec/ticket.
+ - Verify the diff fulfills all requirements and acceptance criteria from the originating spec, ticket, and DDR, including every `REQ-###`, `INV-###`, `NFR-###`, `SEC-###`, and `ERR-###` in its traceability matrix.
+ - Flag as `🔴 Blocking` any behavior, schema, endpoint, number, or command the diff invents without a cited `DEC-###`, spec ID, or repository `path:line`. Unsourced invention is a specification-fidelity defect, not a style nit.
- **Test Tampering Audit**: Flag as `🔴 Blocking` any test tampering: disabled or skipped tests (`.skip`, `xit`), deleted assertions, weakened checks (`expect(true).toBe(true)`, `toBeDefined()`), or System-Under-Test mocking.
+ - **MVP / Prototype Debt Audit**: Flag as `🔴 Blocking` any missing boundary validation, authorization/tenancy check, idempotency, error mapping, observability, migration/rollback, or production hardening; any placeholder, `TODO`, fake data, dummy token, or stub in production paths; and any "MVP", "prototype", "temporary", or "hardening later" justification. The specification's production gates are not optional.
- Flag any unagreed public seams, missing boundary checks, dummy/mock data stores, or deferred `// TODO` stubs.
3. **Audit Axis 2 — Standards, Security & Minimalism**:
- **Security & Concurrency**: Check for injection risks, missing BOLA/IDOR tenant checks, TOCTOU race conditions, non-idempotent mutations, and network calls inside DB transactions.
- **Secrets & Supply Chain**: Flag hardcoded credentials, committed `.env` files, unsafe secret comparison, unpinned or typosquatted new dependencies, and CI steps that pipe remote scripts into a shell.
- **Architecture & Quality**: Flag shallow pass-through wrappers, inward dependency violations, float currency math, boolean flag clusters, and Fowler smells.
- **Ponytail Minimalism**: Flag unnecessary dependencies, speculative abstractions, duplicate components/templates, or multi-file boilerplate replaceable by stdlib or existing codebase helpers.
4. **Report prioritized findings**:
- Group findings by `🔴 Blocking`, `🟡 Structural`, and `🟢 Nit` with clickable `[file.ext](file:///abs/path/file.ext#L10-L20)` links using the **real** line numbers from the diff (never invent ranges) (`[Location] -> [Concrete Problem] -> [Exact Fix]`).
- Conclude with **`APPROVE`**, **`APPROVE WITH NITS`**, or **`REQUEST CHANGES`**.