code-review · git:20261102.bc6f8af · 2026-11-02 · sha256 1892f36cdb32d239

code-review git:20261102.bc6f8afA

Immutable. This exact content never changes and is served at /api/v1/blob/1892f36cdb32d239.

No tool to install first
claude plugin marketplace add https://markdownregistry.com/mp/a/art_gfo4vuwbo7kywoqr/1892f36cdb32d239365126198efd2ae7c44d0bf0cc15f8b4cb82af4a10d511d6.json

Then /plugin install code-review@markdownregistry-gfo4vuwbo7kywoqr in Claude Code. It installs this exact version, the one graded A here, pinned to the commit it was graded at, and leaves it there.

---
name: code-review
description: Reviews code changes along two axes—specification fidelity and engineering standards (security, concurrency, architecture, and Ponytail minimalism). Use when reviewing diffs, pull requests, branches, or checking code quality.
---

# Code Review

Review the diff between `HEAD` and a base reference along two axes: **Specification Fidelity** and **Engineering Standards**.

## Decision tree

1. **Is the base ref (commit, branch, or working-tree diff) resolved and non-empty?**
   - **No** → Inspect `git status` and `git diff` (or ask the user for the base ref) before starting.
   - **Yes** → Proceed to step 2.
2. **Are you reviewing your own recent implementation or a multi-module diff?**
   - **Yes** → Delegate the review to `adversarial-reviewer` via `invoke_subagent` so findings remain free of confirmation bias.
   - **No** → Execute the review workflow below directly.

## Review workflow

1. **Capture diff & check unchanged callers**:
   - Run `git diff <base>...HEAD` (or `git diff`) via `run_command`.
   - For every modified function signature or shared type, run `grep_search` across the repo to confirm unchanged callers are not broken.
2. **Audit Axis 1 — Specification Fidelity & Test Integrity**:
   - Verify the diff fulfills all requirements and acceptance criteria from the originating spec/ticket.
   - **Test Tampering Audit**: Flag as `🔴 Blocking` any test tampering: disabled or skipped tests (`.skip`, `xit`), deleted assertions, weakened checks (`expect(true).toBe(true)`, `toBeDefined()`), or System-Under-Test mocking.
   - Flag any unagreed public seams, missing boundary checks, dummy/mock data stores, or deferred `// TODO` stubs.
3. **Audit Axis 2 — Standards, Security & Minimalism**:
   - **Security & Concurrency**: Check for injection risks, missing BOLA/IDOR tenant checks, TOCTOU race conditions, non-idempotent mutations, and network calls inside DB transactions.
   - **Secrets & Supply Chain**: Flag hardcoded credentials, committed `.env` files, unsafe secret comparison, unpinned or typosquatted new dependencies, and CI steps that pipe remote scripts into a shell.
   - **Architecture & Quality**: Flag shallow pass-through wrappers, inward dependency violations, float currency math, boolean flag clusters, and Fowler smells.
   - **Ponytail Minimalism**: Flag unnecessary dependencies, speculative abstractions, duplicate components/templates, or multi-file boilerplate replaceable by stdlib or existing codebase helpers.
4. **Report prioritized findings**:
   - Group findings by `🔴 Blocking`, `🟡 Structural`, and `🟢 Nit` with clickable `[file.ext](file:///abs/path/file.ext#L10-L20)` links using the **real** line numbers from the diff (never invent ranges) (`[Location] -> [Concrete Problem] -> [Exact Fix]`).
   - Conclude with **`APPROVE`**, **`APPROVE WITH NITS`**, or **`REQUEST CHANGES`**.