infra-review ยท diff
git:20260717.eac5e0b to git:20260718.42bcc8e
12 added, 30 removed. Audit A to A.
---
name: infra-review
- description: Review infrastructure-as-code and deployment configuration without modifying it. Use before plan, apply, or deploy when changes may affect network exposure, IAM or RBAC, secrets, encryption, state, destructive replacement, availability, cost, rollout, or recovery.
+ description: Review infrastructure-as-code and rendered deployment configuration without modifying it. Use before plan, apply, or deploy when targeting, replacement, state, availability, cost, ordering, or recovery blast radius may change.
---
# Infrastructure Review
- Assess operational blast radius using the diff, full resource definitions, repository conventions, and available non-mutating evidence.
-
- ## Establish Scope
-
- 1. Read applicable repository instructions.
- 2. Inspect status, changed paths, diffs, relevant commits, and surrounding modules or overlays.
- 3. Confirm the comparison target and affected environments, accounts, regions, clusters, or tenants.
- 4. Use local refs by default. Fetch only when current remote state is required and permitted.
- 5. Identify the tooling and source-to-rendered-config path before running checks.
-
- ## Review Workflow
-
- 1. Rank changes by blast radius: state backends, production targeting, IAM, networks, databases, storage, compute, deployment, then low-risk metadata.
- 2. Check public exposure, least privilege, secret handling, encryption, container identity, dependency pinning, and supply-chain sources.
- 3. Check resources that may be destroyed or replaced, data migration, backups, deletion protection, dependency ordering, drift, and partial-apply recovery.
- 4. Check environment targeting, rollout order, health checks, resource bounds, disruption behavior, rollback, and observability.
- 5. Check material cost drivers, unbounded storage or traffic, oversized capacity, and cross-region transfer.
- 6. Review existing plan, render, diff, or dry-run evidence when available. Run only repository-supported non-mutating checks appropriate to the requested review.
-
- ## Finding Standard
+ Own pre-deployment infrastructure blast-radius analysis using non-mutating evidence.
- For each actionable finding include severity, exact file and line, affected environment, concrete blast radius, failure path, smallest safe correction, and evidence. Verify whether an attribute truly forces replacement before claiming destruction.
+ ## Workflow
- Block on confirmed public exposure, privilege escalation, secret leakage, unprotected stateful destruction, unsafe state migration, or production rollout without a credible recovery path.
+ 1. Confirm the comparison target, source-to-rendered path, tooling, and affected environment using safe redacted identifiers.
+ 2. Rank changed resources by blast radius and inspect full definitions and dependency ordering.
+ 3. Check targeting, replacement or destruction, state and migration safety, data protection, partial-apply recovery, availability, disruption, capacity, and material cost.
+ 4. Verify provider or tool semantics from local versions or authoritative sources before claiming replacement or destruction.
+ 5. Run only trusted repository-supported non-mutating plan, render, diff, or dry-run checks when authorized.
+ 6. Delegate exploit analysis to `security-review`, dependency provenance to `dependency-review`, CI mechanics to `ci-review`, and cross-cutting runtime readiness to `rollout-readiness-review`.
- ## Guardrails
+ Report severity, exact location, redacted environment reference, concrete blast radius, failure path, smallest correction, evidence, and uncertainty. Describe confirmed public exposure, privilege escalation, secret leakage, unprotected destruction, unsafe state migration, or missing recovery as blocking findings; do not claim authority to block an operation.
- - Keep the review read-only. Never apply, deploy, install, upgrade, delete, destroy, or modify cloud state.
- - Do not echo credentials, account identifiers, internal addresses, or sensitive plan output.
- - Do not assume provider semantics; verify version-sensitive behavior from local versions or official documentation.
- - Do not add scanners or policy frameworks merely to complete the review.
- - State when missing credentials, backends, rendered output, or tooling limits confidence.
+ Never apply, deploy, install, upgrade, delete, destroy, or modify cloud state. Do not expose sensitive plan output or add policy frameworks merely for the review.
- Lead with findings, then summarize scope, destructive changes, cost impact, checks, and remaining uncertainty.
+ Finish with findings or no-findings, scope, destructive effects, cost impact, checks, and confidence limits.