audit-and-fix ยท diff

v5.0.0 to v5.0.0

40 added, 76 removed. Audit A to A.

What this update changes in the checks

No check changed: every fixed check gives the same answer before and after this update.

A tripped check is a label, not a verdict: read the matched text and the lines below. This week's updates that newly trip a check.

---
name: audit-and-fix
- description: Use when Accessibility auditing and remediation workflow combining detection, prioritization, and practical code fixes for WCAG 2.2 AA compliance issues.
+ description: "Use when Use for dual-purpose remediation: Accessibility auditing (WCAG 2.2 AA) and Deep Backend Security Remediation (Cloudflare protocols, Auth, CSRF, JWT)."
version: 5.0.0
last-updated: 2026-09-13
skills:
- fixing-accessibility
- build-primitive
- baseline-ui
+ - cf-security-audit-core
+ - cf-web-protocol-and-auth
+ - cf-attack-classes
tools: Read, Grep, Glob, Bash, Edit, Write
scripts-binding:
- .agent/scripts/lint_runner.js
- .agent/scripts/verify_all.js
---
# Audit and Fix โ€” Accessibility Remediation Workflow
- ## Mandatory Pre-Flight Context Inspection
-
- Before generating, refactoring, or reviewing code in the `audit-and-fix` domain, inspect these 5 critical parameters:
-
- 1. **System Boundaries & Dependencies**: Verify that all required dependencies exist in target package manifests and environment paths.
- 2. **Runtime Context & Platform Invariants**: Confirm target platform constraints (Node.js, Browser, Mobile OS, Edge runtime) before applying APIs.
- 3. **Execution Guardrails**: Identify potential side-effects, state mutations, and unhandled asynchronous exceptions.
- 4. **Validation & Type Contracts**: Validate input data schemas and strict type constraints across all module interfaces.
- 5. **Observability & Proof of Execution**: Ensure execution produces tangible verification signals (terminal output, tests, metrics).
-
- ## Activation Boundaries
-
- - **Activate when:** Use when Accessibility auditing and remediation workflow combining detection, prioritization, and practical code fixes for WCAG 2.2 AA compliance issues.
- - **DO NOT activate when:** The task falls outside the `audit-and-fix` domain or is managed by a different dedicated specialist.
-
- ## ๐Ÿ” Multi-Pass Execution Protocol
-
- Execute all non-trivial tasks through this 7-pass cognitive loop:
-
- | Pass | Phase | Core Action |
- | :--------- | :--------------- | :------------------------------------------------------------------------------------------- |
- | **Pass 1** | **Understand** | Deconstruct the user's explicit objective, implicit requirements, and platform constraints. |
- | **Pass 2** | **Plan** | Decompose the task into smallest logical steps; map dependencies and required tool calls. |
- | **Pass 3** | **Execute** | Implement the solution with production-grade craft, zero placeholders, and strict typing. |
- | **Pass 4** | **Verify** | Run linters, unit tests, or compiler checks to validate structural correctness. |
- | **Pass 5** | **Attack** | Perform an adversarial review searching for edge-case failures, race conditions, and traps. |
- | **Pass 6** | **Improve** | Eliminate discovered friction, optimize performance, and harden error boundaries. |
- | **Pass 7** | **Quality Gate** | Enforce Verification-Before-Completion (VBC) with concrete terminal proof before finalizing. |
-
---
## ๐Ÿ› ๏ธ Technical Architecture & Reference Recipes
---
---
## 4-Step Remediation Pipeline
### 1. Automated Violation Detection
- Scan component code for:
+ Scan component code for **Accessibility**:
- Missing `alt` tags on `<img>` elements.
- Form controls (`<input>`, `<select>`) missing associated `<label>` or `aria-label`.
- Buttons with icon-only content missing `aria-label`.
- Non-interactive elements (`<div>`, `<span>`) with `onClick` handlers missing `role="button"` and `tabIndex={0}`.
+ Scan backend code for **Security (Cloudflare Protocols)**:
+
+ - JWTs lacking explicit `alg`, `aud`, and `exp` validation.
+ - Missing CSRF tokens on state-mutating HTTP methods (`POST`, `PUT`, `DELETE`).
+ - Improper request framing or missing cache control headers.
+ - Hardcoded secrets or unsanitized user inputs at boundaries.
+
### 2. Prioritization Matrix
- | Severity Level | Violation Type | Remediation Action |
- | -------------------------- | -------------------------------------------------------------------------------- | ---------------------------------------------------------------------- |
- | ๐Ÿ”ด **Blocker (Level A)** | Inaccessible form inputs, un-trapped focus in modal, zero keyboard access | Add explicit `<label>`, focus trap, and keyboard handlers immediately. |
- | ๐ŸŸ  **Critical (Level AA)** | Low text contrast ratio ($< 4.5:1$), missing ARIA states on custom dropdowns | Adjust text colors to OKLCH contrast targets; add `aria-expanded`. |
- | ๐ŸŸก **Moderate (Level AA)** | Missing landmark regions (`<main>`, `<nav>`, `<header>`), heading hierarchy gaps | Wrap layout blocks in semantic HTML5 tags. |
+ | Severity Level | Violation Type | Remediation Action |
+ | -------------------------- | --------------------------------------------------------------------------------- | ----------------------------------------------------------------------- |
+ | ๐Ÿ”ด **Blocker (Level A)** | Inaccessible form inputs, zero keyboard access, **Auth Bypass**, **Missing CSRF** | Add explicit `<label>`, focus trap, validate JWT `aud`/`exp`, add CSRF. |
+ | ๐ŸŸ  **Critical (Level AA)** | Low text contrast ratio ($< 4.5:1$), **Broken Cache**, **Weak Framing** | Adjust colors to OKLCH targets; harden cache-control & framing. |
+ | ๐ŸŸก **Moderate (Level AA)** | Missing landmark regions (`<main>`, `<nav>`), heading hierarchy gaps | Wrap layout blocks in semantic HTML5 tags. |
### 3. Concrete Code Fix Examples
+ #### Accessibility Examples
+
```tsx
// BEFORE (Inaccessible)
<div onClick={submitForm} className="btn">Submit</div>
// AFTER (Accessible)
<button type="submit" onClick={submitForm} className="btn">Submit</button>
```
```tsx
// BEFORE (Icon Only Button)
<button onClick={openSettings}><SettingsIcon /></button>
// AFTER (Accessible Icon Button)
<button onClick={openSettings} aria-label="Open settings"><SettingsIcon aria-hidden="true" /></button>
```
- ---
-
- ## ๐Ÿšจ Edge-Case & Failure Mode Matrix
-
- | Scenario | Risk | Mitigation Strategy |
- | :------------------------------------- | :--------------------------------------------------- | :------------------------------------------------------------------------------ |
- | **Empty or Null Inputs** | Unhandled exception or unexpected rendering collapse | Enforce fallback guards, optional chaining, and explicit empty state handlers |
- | **Network Timeout / Latency** | Hanging operations or duplicate side-effects | Implement bounded abort controllers, exponential backoff, and idempotency keys |
- | **Concurrency / Race Conditions** | Stale state overwrite or inconsistent data mutations | Use atomic transactions, mutex locking, or cancel-on-resubmit controls |
- | **Invalid Schema / Malformed Payload** | Downstream runtime errors or security injection | Validate boundary payloads with Zod/Pydantic schemas prior to execution |
- | **Resource / Memory Saturation** | OOM errors, frame drops, or memory leaks | Clean up listeners, cancel active timers, and enforce pagination/virtualization |
-
- ---
-
- ## ๐Ÿค– LLM-Specific Traps Table
-
- | Anti-Pattern | What AI Commonly Does Wrong | What Is Actually Correct |
- | :------------------------------ | :-------------------------------------------------------------------------------- | :----------------------------------------------------------------------------- |
- | **Hardcoded Secret Pattern** | Committing API keys, tokens, or private salts into source code | Load credentials strictly via runtime environment variables and secret stores |
- | **Prompt Injection Surface** | Directly concatenating untrusted user input into LLM system prompts | Wrap user content in isolated delimiters and strip injection control sequences |
- | **Missing Authorization Check** | Relying only on authentication token presence without checking tenant/object RBAC | Verify user permissions against the specific target record ID before mutation |
-
- ---
-
- ## ๐Ÿ›๏ธ Tribunal Verification & Guardrails
-
- **Active Reviewers:** `security-auditor` ยท `penetration-tester` ยท `backend-security-expert`
- **Slash Command:** `/review` or `/tribunal-full`
+ #### Security Examples
- ### โœ… Pre-Flight Self-Audit Checklist
+ ```ts
+ // BEFORE (Insecure JWT Validation)
+ const decoded = jwt.verify(token, secret);
- ```
- โœ… Are user inputs sanitized and treated as untrusted at system boundaries?
- โœ… Are secrets loaded strictly via environment variables with zero hardcoding?
- โœ… Is least-privilege enforcement active on APIs, tokens, and storage buckets?
- โœ… Are prompt-injection delimiters and sanitizers wrapped around LLM inputs?
- โœ… Did I verify encryption in transit and at rest for sensitive customer data?
+ // AFTER (Secure JWT Validation - Enforce Audience & Alg)
+ const decoded = jwt.verify(token, secret, {
+ algorithms: ['HS256'],
+ audience: 'https://api.example.com',
+ maxAge: '1h',
+ });
```
- ### ๐Ÿ›‘ Verification-Before-Completion (VBC) Protocol
-
- **CRITICAL:** You must follow a strict "evidence-based closeout" state machine.
+ ```tsx
+ // BEFORE (Missing CSRF)
+ <form action="/api/update-profile" method="POST">
+ <input name="email" type="email" />
+ </form>
- - โŒ **Forbidden:** Declaring a task complete because the output "looks correct."
- - โœ… **Required:** You are explicitly forbidden from finalizing any task without providing **concrete evidence** (terminal output, passing test suites, compiler success, or equivalent operational proof) that your output works as intended.
+ // AFTER (Secure with CSRF Token)
+ <form action="/api/update-profile" method="POST">
+ <input type="hidden" name="csrfToken" value={csrfToken} />
+ <input name="email" type="email" />
+ </form>
+ ```