adr-generation ยท diff

v1.1.0 to v6.0.0

79 added, 3 removed. Audit A to A.

---
name: adr-generation
- description: 'Formalizes architectural decisions into machine-readable ADR (Architecture Decision Record) documents.'
- version: 1.1.0
- last-updated: 2026-09-26
+ description: "Use when executing, coordinating, planning, or reviewing adr generation agent workflows, cognitive loops, and architecture standards."
+ version: 6.0.0
+ last-updated: 2026-09-29
skills:
- fabel-protocol
+ tools: Read, Grep, Glob, Bash, Edit, Write
+ scripts-binding:
+ - .agent/scripts/lint_runner.js
+ - .agent/scripts/verify_all.js
---
# ADR Generation Skill
+ ## Mandatory Pre-Flight Context Inspection
+ Before reading, generating, or refactoring code in the `adr-generation` domain, inspect these 5 critical parameters:
+ 1. **System Boundaries & Dependencies**: Verify that all required dependencies exist in target package manifests and environment paths.
+ 2. **Runtime Context & Platform Invariants**: Confirm target platform constraints (Node.js, Browser, Mobile OS, Edge runtime) before applying APIs.
+ 3. **Execution Guardrails**: Identify potential side-effects, state mutations, and unhandled asynchronous exceptions.
+ 4. **Validation & Type Contracts**: Validate input data schemas and strict type constraints across all module interfaces.
+ 5. **Observability & Proof of Execution**: Ensure execution produces tangible verification signals (terminal output, tests, metrics).
+
+
+ ## Activation Boundaries
+ - **Activate when:** Use when executing, coordinating, planning, or reviewing adr generation agent workflows, cognitive loops, and architecture standards.
+ - **DO NOT activate when:** The task falls outside the `adr-generation` domain or is managed by a different dedicated specialist agent.
+
+
+ ## ๐Ÿ” Multi-Pass Execution Protocol
+
+ | Pass | Phase | Core Action | Adaptive Depth |
+ |:---|:---|:---|:---|
+ | **Pass 1** | **Understand** | Deconstruct the user's explicit objective, implicit requirements, and platform constraints. | Fast / Standard / Deep |
+ | **Pass 2** | **Plan** | Decompose task into smallest logical steps; map dependencies, affected files, and tool calls. | Standard / Deep |
+ | **Pass 3** | **Execute** | Implement solution with production-grade craft, zero placeholders, and strict typing. | All Modes |
+ | **Pass 4** | **Verify** | Run linters, unit tests, or compiler checks to validate structural correctness. | All Modes |
+ | **Pass 5** | **Attack & Falsify** | Perform adversarial search for edge-case failures, counterexamples, race conditions, and traps. | Standard / Deep |
+ | **Pass 6** | **Harden** | Eliminate discovered friction, optimize performance, and harden error boundaries. | Standard / Deep |
+ | **Pass 7** | **Quality Gate** | Enforce Verification-Before-Completion (VBC) with concrete terminal proof before finalizing. | All Modes |
+
+
Use this skill to produce formal Architecture Decision Records.
## ๐Ÿ”ด Hallucination Traps
- โŒ **Creating ADRs for trivial things** โ†’ โœ… Only generate ADRs for decisions that affect boundaries, dependencies, or scale.
- โŒ **Presenting one option as an "Alternative"** โ†’ โœ… Always research and list at least 2 viable alternatives.
- โŒ **Inventing Consequences** โ†’ โœ… Focus on concrete operational or code-level consequences (e.g., "Requires manual DB migrations").
## ๐Ÿ“‹ Pre-Flight Checklist
1. Have we identified the core problem?
2. Are there at least two viable alternatives?
3. Did we confirm the Minimal-Change Principle?
## ๐Ÿ“ ADR Markdown Template
Use the following strict template when generating an ADR. Save the file in `.agent/architecture/adrs/YYYY-MM-DD-title.md`.
```markdown
# ADR: [Short Descriptive Title]
## Context
[What is the problem we are solving?]
## Decision
[What is the selected approach?]
## Alternatives Considered
1. **[Option A]**: [Why it was rejected]
2. **[Option B]**: [Why it was rejected]
## Trade-offs
[What are the downsides of the chosen Decision?]
## Consequences
[What does this decision force us to do later? What are the operational impacts?]
```
## ๐Ÿ›ก๏ธ Verification-Before-Completion (VBC)
Before concluding, verify that the `system-model.yml` has been updated to reflect this ADR.
+
+ ## ๐Ÿšจ Edge-Case & Failure Mode Matrix
+
+ | Scenario | Risk | Production Mitigation |
+ |:---|:---|:---|
+ | **Empty or Null Inputs** | Unhandled exception or unexpected rendering collapse | Enforce fallback guards, optional chaining, and explicit empty state handlers |
+ | **Network Timeout / Latency** | Hanging operations or duplicate side-effects | Implement bounded abort controllers, exponential backoff, and idempotency keys |
+ | **Concurrency / Race Conditions** | Stale state overwrite or inconsistent data mutations | Use atomic transactions, mutex locking, or cancel-on-resubmit controls |
+ | **Invalid Schema / Malformed Payload** | Downstream runtime errors or security injection | Validate boundary payloads with Zod/Pydantic schemas prior to execution |
+ | **Resource / Memory Saturation** | OOM errors, frame drops, or memory leaks | Clean up listeners, cancel active timers, and enforce pagination/virtualization |
+
+
+ ## ๐Ÿค– LLM-Specific Traps Table
+
+ | Anti-Pattern | What AI Commonly Does Wrong | What Is Actually Correct |
+ |:---|:---|:---|
+ | **Hallucinated Tool Capabilities** | Assuming an external library or CLI command exists without verification | Run a verification check or verify package.json before referencing tools |
+ | **Premature Completion Claim** | Declaring a task finished because code was generated without verification | Execute tests, linters, or terminal commands to provide concrete proof |
+ | **Context Bloat Dumping** | Pasting entire multi-thousand-line files into prompt context | Extract targeted excerpts, symbols, and signatures to preserve tokens |
+
+
+ ## ๐Ÿ›๏ธ Tribunal Verification & Guardrails
+
+ **Active Reviewers:** `orchestrator` ยท `agent-organizer` ยท `logic-reviewer`
+ **Slash Command:** `/review` or `/tribunal-full`
+
+ ### ๐Ÿ”ฌ Evidence Standard (Tri-State Verification)
+ Every finding, audit statement, or completion claim must classify its factual certainty:
+ - **`[OBSERVED]`**: Directly confirmed in the codebase or verified via executed terminal command.
+ - **`[INFERRED]`**: Logically deduced from code patterns, architectural data flow, or schema relations.
+ - **`[UNVERIFIED]`**: Speculative hypothesis or runtime possibility requiring active testing or measurement.
+
+ ### โœ… Pre-Flight Self-Audit Checklist
+ ```
+ โœ… Did I deconstruct the root objective before proposing architecture?
+ โœ… Did I identify dependencies, bottlenecks, and parallelizable sub-tasks?
+ โœ… Did I avoid over-engineering and select the simplest effective pattern?
+ โœ… Did I verify assumptions with concrete file reads instead of speculation?
+ โœ… Did I establish measurable verification criteria before completion?
+ ```
+
+ ### ๐Ÿ›‘ Verification-Before-Completion (VBC) Protocol
+ **CRITICAL:** You must follow a strict "evidence-based closeout" state machine.
+ - โŒ **Forbidden:** Declaring a task complete because the output "looks correct."
+ - โœ… **Required:** You are explicitly forbidden from finalizing any task without providing **concrete evidence** (terminal output, passing test suites, compiler success, or equivalent operational proof) that your output works as intended.