review SKILL.md skillA

review from riot-org/riot is an agent skill: a SKILL.md folder an AI agent loads when a task calls for it.

Install it, pinned

mdr add riot-org/riot/review@git:20260817.d00a470

Pins git:20260817.d00a470 in mdr.lock. Pin the fingerprint instead.

Audit grade: A, 17 of 17 checks passed
Kind: SKILL.md skill
Repository: riot-org/riot
Path: .riot/skills/review/SKILL.md
Versions recorded: 1
Latest version: git:20260817.d00a470, committed Aug 17, 2026
Size: 4,221 bytes
Repository stars: 22
License: a license file GitHub does not identify

审查一批改动时用。缺陷优先，并按这个仓库特有的失效方式去找问题——那些编译通过、类型正确、看起来合理的写法。.

Collected from public GitHub. Every version is saved exactly as it was and never changes. Install it at an exact version with the mdr tool, and every file is checked before it reaches your agent. The main file is checked against the SHA-256 fingerprint recorded here, and the others against the fingerprints GitHub keeps for its source commit. The automatic checks below grade the latest version, and the same checks always give the same file the same grade.

What the file says

# 审查改动

## 先定范围

```bash
git diff                    # 未提交的
git diff --stat master...HEAD   # 相对基线分支的整条分支
```

范围大的时候起一个 `explore` 子 agent 去摸背景（它只读、便宜），自己留着
上下文做判断。

## 该找什么

这个仓库的 bug 基本都是**「编译通过、类型正确、看起来合理」**的那种。所以
不要花力气在命名、格式、能不能少写两行上——那些 clippy 和 fmt 管了。按下面
这几类去找：

**1. 静默的错答案。** 结果不完整而没说出来是最典型的：截断了、超时提前收工、
搜索没走完、工具结果被落盘替换成预览——只要模型可能把半份东西当全部，就是
一个 bug，而它不报错不崩，只是结论错。

真实案例：搜索因超时收工且没有匹配时返回「没有找到」，那是把「没搜」说成
「不存在」，模型据此断定这东西不存在。

**2. fail-closed 的方向反了。** 认不出的输入、解析失败、超时、无人应答，
必须落在保守那一侧。逐项问：这条路上「不确定」会变成「放行」吗？

- 权限：`ask` 在无人应答时必须收敛成 **deny**，不是 allow。
- 工具：认不出的类型/参数按「会写」算，不按「只读」算。
- 判危：判不准必须是 Hold，不能是 Safe。

**3. 安全检查被绕过。** 决策链的顺序是有意义的：安全检查排在 bypass 模式
**前面**，工具自己返回的 `Allow` **不是终点**。改动里如果有提前 `return`、
新增的短路、或者把 `Passthrough` 改成 `Allow`，都要问一遍它是不是跳过了
第 4 步。

同类：hook 的 `allow` 不能压过 settings 的 deny/ask；分类器的权力不能超过
bypass 模式（判据是 `yields_to_bypass()`）。

**4. 有实现没测试守着。** 这是最难看出来的一类，而仓库里真出过：决策链
第 3 步拿到工具的 `Allow` 后必须继续走安全检查，实现是对的，但**没有任何
测试守着那一行**。

审查时对每个关键分支问：把这行删掉/改反，会有测试红吗？答不上来就是个发现。
碰上权限层、路径围栏、文件工具、进程执行器，直接建议跑 `mutate`。

**5. 断言的是「失败了」还是「以正确的理由失败」。** 只断言 `!is_ok` 往往
不够。同一个拒绝，理由从「你还没读过」变成「文件内容对不上」，对模型是
实打实的区别——前者让它先读，后者让它以为有人在并发改文件，白跑一轮。
…

Read the whole file at its exact version.

How to install

The exact contents, by fingerprint

mdr add riot-org/riot/review@sha256:115946b114eff565

The line at the top of this page pins the label git:20260817.d00a470, which is what most people want. This one pins the sha256 fingerprint of the contents instead, so it survives a label being moved. Either way the exact version is written to mdr.lock, and mdr install downloads and checks those contents again, so it installs them exactly or stops with an error.

Badge

[![mdr](https://markdownregistry.com/badge/art_2plboayezswvcwrr.svg)](https://markdownregistry.com/a/art_2plboayezswvcwrr)

4 badge image fetches in 30 days. What the badge shows.

Versions

The registry has recorded 1 version of this file, committed on Aug 17, 2026.

version	committed	commit	size	audit
git:20260817.d00a470 latest	2026-08-17	d00a470	4,221 B	A	view

Audit of the latest version

A 17 of 17 checks passed. Fixed automatic checks with no AI involved, so the same checks give the same answer every run.

pass: Frontmatter block present
pass: Frontmatter declares a name
pass: Frontmatter declares a description
pass: Size between 200 bytes and 200 KB (4221 bytes)
pass: No zero-width or bidi control characters
pass: No instruction hidden inside an HTML comment
pass: No link to an exfiltration or paste host
pass: No credential-shaped string
pass: No instruction to send local credentials anywhere
pass: No text hidden with inline styles
pass: No prompt-injection phrasing
pass: No curl or wget piped into a shell
pass: No recursive delete of root, home or parent
pass: No instruction to read or print local credentials
pass: No base64 blob over 200 characters
pass: No link to a raw IP address
pass: No script tag

Source

GitHub

riot-org/riot · 22 stars · license a license file GitHub does not identify · pushed 2026-10-29 · branch master

API

GET https://markdownregistry.com/api/v1/artifacts/art_2plboayezswvcwrr
GET https://markdownregistry.com/api/v1/resolve?ref=riot-org/riot/review
GET https://markdownregistry.com/api/v1/blob/115946b114eff565f2669dd9f3ea91be4a6a59de39852f95a46066b7ab3fb037

Your AI assistant does the legwork. You hear about the deals worth your word. Hand yours the standing instructions at modelranch.com and it joins the network that reads files like this one.

Guides: the SKILL.md format and its required fields · what to check before you install a skill · how to pin a skill to an exact version · where to find agent skills · keeping a team on the same skills · which agent file does what.

More from riot-org/riot

add-command SKILL.md skill

riot-org/riot · .riot/skills/add-command/SKILL.md · 给前端加一个 Tauri 命令时用。要改五处，漏了其中三处只表现为运行时「command not found」；权限文件还有个先后顺序的坑会让 build.rs 直接 panic。