Test Assertion Effectiveness 常に PASS するテストの検出 SKILL.md skillA

This file is byte-identical to the first copy the registry indexed. Same content hash, so the same checks give both the same grade.

Test Assertion Effectiveness 常に PASS するテストの検出 from s977043/river-review is an agent skill: a SKILL.md folder an AI agent loads when a task calls for it.

Install it, pinned
mdr add s977043/river-review/Test Assertion Effectiveness 常に PASS するテストの検出@v0.1.0

Pins v0.1.0 in mdr.lock. Pin the fingerprint instead.

Audit grade
A, 17 of 17 checks passed
Kind
SKILL.md skill
Repository
s977043/river-review
Path
plugin-dist/river-review/skills/downstream/test-assertion-effectiveness/SKILL.md
Versions recorded
1
Latest version
v0.1.0, committed Oct 25, 2026
Size
23,175 bytes
Repository stars
7
License
MIT

テストは存在するがアサーションが実質何も検証しておらず、実装が壊れても落ちない(常に PASS する)構造を diff-time で検出する。Check 1 missing assertion(テスト本体にアサーションが無い)、Check 2 tautological assertion(定数同士・入力自身・mock の戻り値自身を assert し SUT に依存しない)、Check 3 nonexistent expected literal(assertDontSee / assertNotContains 等の期待文字列が対象ファイルに実在しない)、Check 4 stale expected value(同一 diff で対象の出力が変わったのに期待値が据え置き)、Check 5 unscoped expectation(汎用的な属性・クラスを応答全体に対して assert し対象要素にスコープされていない)、Check 6 swallowed failure(例外の握り潰しや到達しない位置のアサーションで判定が成立しない)、の 6 Check を対象とする…

Collected from public GitHub. Every version is saved exactly as it was and never changes. Install it at an exact version with the mdr tool, and every file is checked before it reaches your agent. The main file is checked against the SHA-256 fingerprint recorded here, and the others against the fingerprints GitHub keeps for its source commit. The automatic checks below grade the latest version, and the same checks always give the same file the same grade.

What the file says

## Naming / 命名

`skills/README.md` の Naming Q0–Q5 に従って決定した。Q0 では外部プロジェクトの成果物を取り込んでいないため「概念の再実装」に分類され、リネーム(新規命名)が既定となる。Q1 は衝突なし(`assertion` を含む skill id は既存に無い)、Q2・Q3 は参照元の原語が存在しないため適用外、Q4 で既存の `test-*` 命名ファミリ(`test-existence` / `test-naming` / `test-plan-review`)に整合することを確認し、Q5 で「価値(アサーションが有効であること)を名指す」名として `test-assertion-effectiveness` を採用した。機構名(tautology 検出・grep 照合)ではなく価値を名指す点が Q5 の要件である。

## Pattern declaration

Primary pattern: Reviewer
Secondary patterns: Inversion
Why: アサーションの形はパターンとして拾えるが、「そのアサーションが SUT の挙動に依存しているか」の判定は意味的であり、期待値の照合先(テンプレート・コンポーネント)が discover できない差分では実行を止めるゲートが必要である。

## Goal / 目的

テストの「有無」や「粒度」は既存 skill が見るが、**書かれたアサーションが実際に失敗しうるか**は誰も見ていない。アサーションが無効なテストは行を通過するためカバレッジ指標にも現れず、CI が緑であることも有効性の証明にならない(レビュー時点の CI が古い sha で緑だった実例が #1684 に記録されている)。この盲点を diff-time の静的観点として埋める。

次の 6 Check のいずれかに該当し、**そのテストが実装の退行を検知できない**と読み取れる場合に指摘する。report-only(ADR-005)であり、finding / question のみを出力して自動修正はしない。

## Non-goals / 扱わないこと(委譲表)

| 隣接領域                                                   | 委譲先                                        | 分界                                                                                                                                          |
…

Read the whole file at its exact version.

How to install

The exact contents, by fingerprint
mdr add s977043/river-review/Test Assertion Effectiveness 常に PASS するテストの検出@sha256:e561e02e03de5ade

The line at the top of this page pins the label v0.1.0, which is what most people want. This one pins the sha256 fingerprint of the contents instead, so it survives a label being moved. Either way the exact version is written to mdr.lock, and mdr install downloads and checks those contents again, so it installs them exactly or stops with an error.

Badge

mdr badge

[![mdr](https://markdownregistry.com/badge/art_75hqydeemnspuwu7.svg)](https://markdownregistry.com/a/art_75hqydeemnspuwu7)

2 badge image fetches in 30 days. What the badge shows.

Versions

The registry has recorded 1 version of this file, committed on Oct 25, 2026.

versioncommittedcommitsizeaudit
v0.1.0 latest2026-10-25 aac3ee8 23,175 BA view

Audit of the latest version

A  17 of 17 checks passed. Fixed automatic checks with no AI involved, so the same checks give the same answer every run.
  • pass: Frontmatter block present
  • pass: Frontmatter declares a name
  • pass: Frontmatter declares a description
  • pass: Size between 200 bytes and 200 KB (23175 bytes)
  • pass: No zero-width or bidi control characters
  • pass: No instruction hidden inside an HTML comment
  • pass: No link to an exfiltration or paste host
  • pass: No credential-shaped string
  • pass: No instruction to send local credentials anywhere
  • pass: No text hidden with inline styles
  • pass: No prompt-injection phrasing
  • pass: No curl or wget piped into a shell
  • pass: No recursive delete of root, home or parent
  • pass: No instruction to read or print local credentials
  • pass: No base64 blob over 200 characters
  • pass: No link to a raw IP address
  • pass: No script tag

Source

GitHub

s977043/river-review · 7 stars · license MIT · pushed 2026-11-08 · branch main

API

GET https://markdownregistry.com/api/v1/artifacts/art_75hqydeemnspuwu7
GET https://markdownregistry.com/api/v1/resolve?ref=s977043/river-review/Test Assertion Effectiveness 常に PASS するテストの検出
GET https://markdownregistry.com/api/v1/blob/e561e02e03de5ade4953f02c062d29bf35988d5797fdd4023e40c2db91a87f14

Your AI assistant does the legwork. You hear about the deals worth your word. Hand yours the standing instructions at modelranch.com and it joins the network that reads files like this one.

Guides: the SKILL.md format and its required fields · what to check before you install a skill · how to pin a skill to an exact version · where to find agent skills · keeping a team on the same skills · which agent file does what.

More from s977043/river-review

ask-codex SKILL.md skill
s977043/river-review · .claude/skills/ask-codex/SKILL.md · Get a second opinion or independent review from Codex (OpenAI) via the local Codex CLI. Use when the user wants Codex…
git:20260724.d54eafd · audit A · 7 stars
river-review-discipline SKILL.md skill
s977043/river-review · .claude/skills/river-review-discipline/SKILL.md · AI 駆動開発のレビュー品質を安定化させるレビュー規律。レビュー対象を分類し、要件・設計・差分・検証・報告を分けて見て、根拠に基づき approved / needs_revision / blocked / rejected…
git:20260707.9c35a5d · audit A · 7 stars
skill-creator SKILL.md skill
s977043/river-review · .claude/skills/skill-creator/SKILL.md · Design a new Claude Code skill from a concrete use case and produce a repo-ready skill package. Use when the user asks…
git:20261004.95d1f7a · audit A · 7 stars
skill-ops-planner SKILL.md skill
s977043/river-review · .claude/skills/skill-ops-planner/SKILL.md · Create an operating policy and roadmap for a live portfolio of Claude Code skills. Use when the user asks to organize…
git:20260321.857d5ca · audit A · 7 stars
skill-optimizer SKILL.md skill
s977043/river-review · .claude/skills/skill-optimizer/SKILL.md · Evaluate and improve an existing Claude Code skill using explicit success criteria and small controlled changes. Use…
git:20261004.95d1f7a · audit A · 7 stars
AGENTS.md@.codex AGENTS.md file
s977043/river-review · .codex/AGENTS.md
git:20260923.5650e78 · audit A · 7 stars
AGENTS.md AGENTS.md file
s977043/river-review · AGENTS.md
git:20261008.d74129b · audit B · 7 stars
CLAUDE.md CLAUDE.md file
s977043/river-review · CLAUDE.md
git:20261016.787c99c · audit A · 7 stars
Sample Architecture Consistency Review SKILL.md skill
s977043/river-review · examples/skills/architecture-sample/SKILL.md · Checks design/ADR docs for consistency and missing decisions.
v0.1.0 · audit A · 7 stars
Sample Code Quality Pass SKILL.md skill
s977043/river-review · examples/skills/code-quality-sample/SKILL.md · Checks common code quality and maintainability risks.
v0.1.0 · audit A · 7 stars
Sample Test Coverage Review SKILL.md skill
s977043/river-review · examples/skills/test-review-sample/SKILL.md · Evaluates downstream tests for coverage and edge cases.
v0.1.0 · audit A · 7 stars
adversarial-review SKILL.md skill
s977043/river-review · plugin-dist/river-review/skills/agent-skills/adversarial-review/SKILL.md · 敵対的分析手法を統合したレビューの entry skill。認知バイアス対策の3手法 (Pre-mortem / War Game / Logic Torturing)と、宣言・主張と実態の乖離を突く claim-vs-actual…
v0.1.0 · audit A · 7 stars

Every file in s977043/river-review

Other files named Test Assertion Effectiveness 常に PASS するテストの検出

Test Assertion Effectiveness 常に PASS するテストの検出 SKILL.md skill
s977043/river-review · skills/downstream/test-assertion-effectiveness/SKILL.md · テストは存在するがアサーションが実質何も検証しておらず、実装が壊れても落ちない(常に PASS する)構造を diff-time で検出する。Check 1 missing assertion(テスト本体にアサーションが無い)、Check…
v0.1.0 · audit A · 7 stars

Browse by kind, by grade A, or by owner.