test-smell-review SKILL.md skillA

test-smell-review from collectiveai-team/botica is an agent skill: a SKILL.md folder an AI agent loads when a task calls for it.

Install it, pinned
mdr add collectiveai-team/botica/test-smell-review@git:20261020.13637bb

Pins git:20261020.13637bb in mdr.lock. Pin the fingerprint instead.

Audit grade
A, 17 of 17 checks passed
Kind
SKILL.md skill
Repository
collectiveai-team/botica
Path
skills/quality/test-smell-review/SKILL.md
Versions recorded
4
Latest version
git:20261020.13637bb, committed Oct 20, 2026
First version recorded
Aug 9, 2026
Size
12,478 bytes
Repository stars
9
License
a license file GitHub does not identify

Review pytest/unittest, Jest/Vitest/Mocha, or any other language's tests for false-green smells — tests that pass without protecting anything (empty, assertion-free, tautological, mocking the unit under test, echoing a mock back to itself). Use after writing or editing test files, and when the user asks to review test quality, find weak tests, or check whether tests actually catch bugs.

Collected from public GitHub. Every version is saved exactly as it was and never changes. Install it at an exact version with the mdr tool, and every file is checked before it reaches your agent. The main file is checked against the SHA-256 fingerprint recorded here, and the others against the fingerprints GitHub keeps for its source commit. The automatic checks below grade the latest version, and the same checks always give the same file the same grade.

What the file says

# Test Smell Review

A test suite that is 100% green is not proof the code is correct — it is only
proof that no test failed. Apply this judgment whenever tests are written,
edited, or explicitly reviewed: **a test is useful only if some incorrect
implementation would make it fail.** If no such implementation exists, the
test is structurally green regardless of whether the code is right.

## Source

The J1–J6 judgments and the case catalog are adapted from
[`falsegreen-skill`](https://github.com/vinicq/falsegreen-skill) and applied in context, with no
second model call; `references/reference.md` has the catalog and its credits.

## If you're about to write a test, not just review one

This skill reviews tests; the `tdd` skill writes them. When you write a test, derive the expected
value from an independent source (the spec, a docstring, a hand-computed value), not from running
the code once and copying its output, then check it with Steps 1–4 below. A test built from the
output of the code cannot fail when the code is wrong.

## Step 0a: detect the language and framework

- **Python:** `import pytest`/`import unittest`/`from unittest.mock import`,
…

Read the whole file at its exact version.

How to install

The exact contents, by fingerprint
mdr add collectiveai-team/botica/test-smell-review@sha256:9b8ded2657a00361

The line at the top of this page pins the label git:20261020.13637bb, which is what most people want. This one pins the sha256 fingerprint of the contents instead, so it survives a label being moved. Either way the exact version is written to mdr.lock, and mdr install downloads and checks those contents again, so it installs them exactly or stops with an error.

Badge

mdr badge

[![mdr](https://markdownregistry.com/badge/art_dbrlnr3l45woebk7.svg)](https://markdownregistry.com/a/art_dbrlnr3l45woebk7)

1 badge image fetches in 30 days. What the badge shows.

Versions

The registry has recorded 4 versions of this file, between Aug 9, 2026 and Oct 20, 2026, about one every 24 days.

versioncommittedcommitsizeaudit
git:20261020.13637bb latest2026-10-20 13637bb 12,478 BA view · diff
git:20261013.dbceb012026-10-13 dbceb01 14,117 BA view · diff
git:20261012.fb170052026-10-12 fb17005 14,007 BA view · diff
git:20260809.1f1f2bc2026-08-09 1f1f2bc 14,012 BA view

Audit of the latest version

A  17 of 17 checks passed. Fixed automatic checks with no AI involved, so the same checks give the same answer every run.
  • pass: Frontmatter block present
  • pass: Frontmatter declares a name
  • pass: Frontmatter declares a description
  • pass: Size between 200 bytes and 200 KB (12478 bytes)
  • pass: No zero-width or bidi control characters
  • pass: No instruction hidden inside an HTML comment
  • pass: No link to an exfiltration or paste host
  • pass: No credential-shaped string
  • pass: No instruction to send local credentials anywhere
  • pass: No text hidden with inline styles
  • pass: No prompt-injection phrasing
  • pass: No curl or wget piped into a shell
  • pass: No recursive delete of root, home or parent
  • pass: No instruction to read or print local credentials
  • pass: No base64 blob over 200 characters
  • pass: No link to a raw IP address
  • pass: No script tag

Source

GitHub

collectiveai-team/botica · 9 stars · license a license file GitHub does not identify · pushed 2026-11-03 · branch main

API

GET https://markdownregistry.com/api/v1/artifacts/art_dbrlnr3l45woebk7
GET https://markdownregistry.com/api/v1/resolve?ref=collectiveai-team/botica/test-smell-review
GET https://markdownregistry.com/api/v1/blob/9b8ded2657a003618fbf5c2f098ea2bf17f2474712d051018354f40f72d9f4f4

Your AI assistant does the legwork. You hear about the deals worth your word. Hand yours the standing instructions at modelranch.com and it joins the network that reads files like this one.

Guides: the SKILL.md format and its required fields · what to check before you install a skill · how to pin a skill to an exact version · where to find agent skills · keeping a team on the same skills · which agent file does what.

More from collectiveai-team/botica

AGENTS.md AGENTS.md file
collectiveai-team/botica · AGENTS.md
git:20261028.be26064 · audit A · 9 stars
AGENTS.md@catalog/rules/writing/agents-md-refs-exist/fixtures/invalid AGENTS.md file
collectiveai-team/botica · catalog/rules/writing/agents-md-refs-exist/fixtures/invalid/AGENTS.md
git:20261027.853ff8a · audit B · 9 stars
CLAUDE.md@catalog/rules/writing/agents-md-refs-exist/fixtures/invalid/pkg CLAUDE.md file
collectiveai-team/botica · catalog/rules/writing/agents-md-refs-exist/fixtures/invalid/pkg/CLAUDE.md
git:20261027.853ff8a · audit B · 9 stars
AGENTS.md@catalog/rules/writing/agents-md-refs-exist/fixtures/valid AGENTS.md file
collectiveai-team/botica · catalog/rules/writing/agents-md-refs-exist/fixtures/valid/AGENTS.md
git:20261027.853ff8a · audit A · 9 stars
AGENTS.md@catalog/rules/writing/agents-md-refs-exist/fixtures/valid/pkg AGENTS.md file
collectiveai-team/botica · catalog/rules/writing/agents-md-refs-exist/fixtures/valid/pkg/AGENTS.md
git:20261027.853ff8a · audit B · 9 stars
botica-rule-author SKILL.md skill
collectiveai-team/botica · skills/engineering/botica-rule-author/SKILL.md · Write a new botica lint rule, either in the built-in catalog (catalog/rules) or in a catalog of a project…
git:20261020.31feb13 · audit A · 9 stars
engineering-pr-review SKILL.md skill
collectiveai-team/botica · skills/engineering/engineering-pr-review/SKILL.md · PR gate that runs botica, reviews the diff with the upstream code-review skill and writes the body with the pr skill…
git:20261020.7ea4422 · audit A · 9 stars
engineering-refactor SKILL.md skill
collectiveai-team/botica · skills/engineering/engineering-refactor/SKILL.md · Refactor an existing codebase in small, tested slices while keeping its local conventions, using botica for the rules…
git:20261020.7ea4422 · audit A · 9 stars
pr SKILL.md skill
collectiveai-team/botica · skills/engineering/pr/SKILL.md · Use when writing a PR body. Follow the repository's .github/pull_request_template.md.
git:20261020.43b8a7e · audit A · 9 stars
ask-user SKILL.md skill
collectiveai-team/botica · skills/productivity/ask-user/SKILL.md · Ask which installed skill or workflow fits the user's situation.
git:20261020.43b8a7e · audit A · 9 stars
handoff SKILL.md skill
collectiveai-team/botica · skills/productivity/handoff/SKILL.md · Compact the current conversation and workspace state into a handoff document for a fresh agent session.
git:20261018.e05a5c3 · audit A · 9 stars
journalist SKILL.md skill
collectiveai-team/botica · skills/productivity/journalist/SKILL.md · Write short daily journal entries for the current session under .journals, maintain a metadata-driven index, and query…
git:20260614.c283430 · audit A · 9 stars

Every file in collectiveai-team/botica

Browse by kind, by grade A, or by owner.